-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blog app] Milestone 7 - Authentication with Devise #7
Conversation
…ram/rails-blog-app into authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Student ,
Status: Approved ✔️ ✔️ ✔️
To Highlight 💪🏻
- No lInter errors✔️
- Installed and used devise ✔️
- The views in devise for the registration and login have been modified by the student to match the wireframes and their styling✔️
- A user can log in with a combination of email and password✔️
- The
current_user
method inApplicationController
has been removed✔️
Good job implementing the requirements 👍 Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Optional Suggestions :
- N/A
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag ichala in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello Dear CR ✋
I hope this message finds you well. I am submitting a pull request for your review and feedback on the implementation of the Blog app: add devise. I, @cherelemma and @Tshobohwa acollaborate to implement the project requirements. We believe the implementation fulfills the project requirements and also maintained the general requirements.
Project Requirements ✔️
current_user
in your ApplicationController to make current user data available to all controllers.current_user
(use the method that you created in your ApplicationController).current_user
(use the method that you created in your ApplicationController).General requirements ✔️
We have thoroughly reviewed the project requirements and cross-checked the implementation of the authentication of the Blog app against the given description to ensure accuracy. All necessary views have been run successfully.
We kindly request a review as your feedback and suggestions are invaluable in ensuring the quality and efficiency of the project.
Thank you in advance for your time and assistance. We are looking forward to your feedback and addressing any concerns to enhance the overall quality of the project.